Gnuplot (GASTON) backend testing #3177

isentropic · 2020-12-03T06:01:32Z

Dear all,
here is the first attempt at making gnuplot (gaston) plots backend. Still very early stage, still testing, too many things remain, but it feels like gnuplot can be a good backend as there have been no hacks implementing it so far.

Please test it like (naturally need to have gaston and gnuplot working beforehand)

using Plots; gaston()
plot(1:10, xlab="gnuplot is not bad at all", xguidefontsize=15, ylab="notbad", yguidefontsize=5, tick_direction=:out, guidefontfamily="Serif")

plot(
       plot(1:10, xlab="gnuplot is not bad at all", xguidefontsize=15, ylab="notbad", yguidefontsize=5, tick_direction=:out, guidefontfamily="Serif"), plot(sin.(1:100))
       )

Not many things work, in fact, most don't. But I think there is potential to this as it behaved very nice so far. Only tested in repl, but jupyter has to work too. Waiting for reviews from @mbaz
q

src/backends/gaston.jl

isentropic · 2020-12-03T06:07:39Z

src/backends/gaston.jl

+function _update_plot_object(plt::Plot{GastonBackend})
+end
+
+function _show(io::IO, ::MIME"image/png", plt::Plot{GastonBackend})


saving figures would be done through this function

@mbaz it would be really helpful if you could help me fill this cuntion correctly

src/backends/gaston.jl

codecov · 2020-12-03T06:14:39Z

Codecov Report

Merging #3177 (87b5b1d) into master (c857d59) will decrease coverage by 1.26%.
The diff coverage is 0.54%.

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
- Coverage   63.76%   62.50%   -1.27%     
==========================================
  Files          25       26       +1     
  Lines        6450     6641     +191     
==========================================
+ Hits         4113     4151      +38     
- Misses       2337     2490     +153

Impacted Files	Coverage Δ
src/backends.jl	`68.29% <0.00%> (-2.05%)`	⬇️
src/backends/gaston.jl	`0.00% <0.00%> (ø)`
src/init.jl	`100.00% <100.00%> (ø)`
src/recipes.jl	`57.36% <0.00%> (-1.26%)`	⬇️
src/layouts.jl	`63.34% <0.00%> (-0.75%)`	⬇️
src/axes.jl	`77.20% <0.00%> (-0.73%)`	⬇️
src/backends/gr.jl	`89.56% <0.00%> (-0.10%)`	⬇️
src/utils.jl	`56.11% <0.00%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c857d59...87b5b1d. Read the comment docs.

src/backends/gaston.jl

isentropic · 2020-12-04T11:33:00Z

More things work now

linetypes = [:path :steppre :steppost :sticks :scatter]
n = length(linetypes)
x = Vector[sort(rand(20)) for i = 1:n]
y = rand(20, n)
plot(x, y, line = (linetypes, 3), lab = map(string, linetypes), ms = 15)

isentropic · 2020-12-04T11:34:46Z

@mbaz I wanted to know if communication with gnuplot is possible? Basically
show commands in gnuplot repl

mbaz · 2020-12-04T17:35:41Z

@isentropic If you mean running arbitrary gnuplot commands, it's planned for the next version (mbaz/Gaston.jl#154)

As for show commands: Gaston (in my private devel branch, which will become 2.0) supports showing ascii, svg, png, sixelgd and canvas on the terminal (as text). Is that what you mean?

isentropic · 2020-12-04T20:13:44Z

http://www.gnuplot.info/docs_5.4/Gnuplot_5_4.pdf
show command as in the docs. So back communication from gnuplot basically

@mbaz

mbaz · 2020-12-05T15:25:17Z

Oh! I thought you meant Julia's show, not gnuplot's. Sorry for the confusion.

This is not supported at the moment -- you can send commands to gnuplot using Gaston.gnuplot_send(), but Gaston does not read back the result. I plan to support this in the next version.

isentropic · 2020-12-07T06:03:30Z

New stuff like axis keywords and stuff added. Comments are welcome

plot(histogram(randn(10000), yscale=:log10), plot(1:500))

isentropic · 2020-12-07T06:08:20Z

Supported args and markers are written in backends.jl I think that this might be ready for some tests now. Can someone help do it? I was never good with tests and how to run them.
Also, @mbaz would you please write up the save function? I'm not sure what would be the right way to export the figures. I think it would be fairly easy, similar to display function

isentropic · 2020-12-07T14:53:05Z

how do i make this a draft? I presed complete review now its green again

daschw · 2020-12-07T14:58:38Z

I tested it and it works amazing (from the REPL) so far. Really nice effort! What are your plans? Do you want to keep working on this PR to add more features, or would you rather merge a first basic PR and continue working on new features in other PRs?

mbaz · 2020-12-07T16:54:56Z

@isentropic What do you need for the save function? Gaston already can save plots in multiple formats: https://github.com/mbaz/Gaston.jl/blob/master/src/gaston_save.jl https://mbaz.github.io/Gaston.jl/stable/introduction/#Saving-plots-1

Awesome work BTW!

BeastyBlacksmith · 2020-12-07T17:07:05Z

how do i make this a draft? I presed complete review now its green again

"Convert to draft" is below the reviewer section

isentropic

@mbaz Would you please look at these comments? For some reason the saving for pdf, latex, and txt works unexpectedly

isentropic · 2020-12-08T06:21:48Z

src/backends/gaston.jl

+    end
+end
+
+function _show(io::IO, mime::MIME{Symbol("image/png")},


@mbaz Image/png I believe is for png figures, as gnuplot has a constant dpi I had add some scaling hacks here

isentropic · 2020-12-08T06:23:07Z

src/backends/gaston.jl

+    "application/x-tex"       => "epslatex",   # NEED fixing TODO
+    "text/plain"              => "dumb",       # NEED fixing TODO
+)
+    @eval function _show(io::IO, ::MIME{Symbol($mime)}, plt::Plot{GastonBackend})


@mbaz, most of the terminals do not work properly and I do not know why. PDF for some reason produces weird output. Also, latex terminals complain about the file format.

isentropic · 2020-12-08T06:27:23Z

@daschw Yeah, I think I need to polish up saving and some more plotting args like plot title and legend box positioning. Then perhaps it would cover the bare minimum for simple 2d plots. Later, I'm planning to add colorbar and 3d plots.

isentropic · 2020-12-10T08:02:11Z

p = plot(rand(50,5), fontfamily="Serif", legendtitle="legend", leg=:outerbottomleft, title="titles are here")

a few more things work, I guess right now it is minimal working verion

VarLad · 2020-12-23T19:50:18Z

@isentropic Great work!
Any idea how long would it take to get it as functional as other backends?
Like, what percent do you think can Gaston backend provide for now, compared to the complete product?
Again, thanks for taking the time!

isentropic · 2020-12-24T03:31:45Z

@clad26 I really wanted to have gaston as an invitation for new contributors really. It is an inferior backend that is very lean in codebase (300 lines only). I think people familiar with gnuplot in general will find it easy to contribute and improve on this. Right I would say that a lot of 2d plots work already, but 3d support is not here yet.

VarLad · 2020-12-31T08:52:35Z

@clad26 I really wanted to have gaston as an invitation for new contributors really. It is an inferior backend that is very lean in codebase (300 lines only). I think people familiar with gnuplot in general will find it easy to contribute and improve on this. Right I would say that a lot of 2d plots work already, but 3d support is not here yet.

Does it provide histogram yet?

isentropic · 2020-12-31T12:35:00Z

Yeah it works

isentropic · 2021-01-05T04:08:28Z

@clad26 if you are interested in this, let me know what features do you need the most

VarLad · 2021-04-25T23:11:44Z

@isentropic It'd be nice if this can be fully completed and merged as a part of plots

Since the artifacts are almost here, this might be good

You can tell me from where can I start implementing 3D and what in 2D is left, so that I can help too?

Also, I'm interested in the first plot time of Gaston+Plots with the latest version of Plots. It'd be nice if you can update the compat in https://github.com/isentropic/Plots.jl/tree/gnuplot

isentropic · 2021-04-26T03:37:58Z

The important think that prevents me from merging this, is the lack of testing and community feedback. This was an experiment of mine to see if gnuplot can even work as a backend for plots. I'd hold off with implementing 3d. We need to test 2d suite for egregious bugs first (I cannot afford to do testing --- that is to use this on daily basis and see what is missing).

Regarding comPat, I'm not sure how to set this up, perhaps you could send a PR to this fork?

If you could assist with this backend, I'd be happy to see contribution

t-bltg · 2021-07-21T23:00:22Z

@isentropic, we now have Gaston in the docs: https://docs.juliaplots.org/latest/generated/gaston 😉

isentropic added 2 commits December 1, 2020 18:46

gnuplot

edb86ff

minimal working gnuplot

fba9791

isentropic requested review from BeastyBlacksmith, daschw and mkborregaard December 3, 2020 06:02

isentropic commented Dec 3, 2020

View reviewed changes

BeastyBlacksmith marked this pull request as draft December 3, 2020 07:57

BeastyBlacksmith reviewed Dec 4, 2020

View reviewed changes

src/backends/gaston.jl Show resolved Hide resolved

more params

fad07e8

new series and axis params

4337cc0

isentropic marked this pull request as ready for review December 7, 2020 14:50

isentropic closed this Dec 7, 2020

isentropic reopened this Dec 7, 2020

saving figures

f017e94

isentropic commented Dec 8, 2020

View reviewed changes

gnuplot version 0.1

87b5b1d

VarLad mentioned this pull request Dec 31, 2020

Update to the notebooks. QuantumBFS/tutorials#14

Merged

t-bltg added enhancement improving existing functionality help wanted labels Jul 5, 2021

BeastyBlacksmith merged commit e58fdf9 into JuliaPlots:master Jul 5, 2021

t-bltg mentioned this pull request Jul 21, 2021

Will you merge more kernels to Plots, such as Gnuplot, and MathGL? #2013

Closed

Uh oh!

Gnuplot (GASTON) backend testing #3177

Gnuplot (GASTON) backend testing #3177

Uh oh!

Conversation

isentropic commented Dec 3, 2020

Uh oh!

Uh oh!

Uh oh!

isentropic Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

isentropic Dec 7, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

isentropic commented Dec 4, 2020

Uh oh!

isentropic commented Dec 4, 2020

Uh oh!

mbaz commented Dec 4, 2020

Uh oh!

isentropic commented Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbaz commented Dec 5, 2020

Uh oh!

isentropic commented Dec 7, 2020

Uh oh!

isentropic commented Dec 7, 2020

Uh oh!

isentropic commented Dec 7, 2020

Uh oh!

daschw commented Dec 7, 2020

Uh oh!

mbaz commented Dec 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BeastyBlacksmith commented Dec 7, 2020

Uh oh!

isentropic left a comment

Choose a reason for hiding this comment

Uh oh!

isentropic Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

isentropic Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

isentropic commented Dec 8, 2020

Uh oh!

isentropic commented Dec 10, 2020

Uh oh!

VarLad commented Dec 23, 2020

Uh oh!

isentropic commented Dec 24, 2020

Uh oh!

VarLad commented Dec 31, 2020

Uh oh!

isentropic commented Dec 31, 2020

Uh oh!

isentropic commented Jan 5, 2021

Uh oh!

VarLad commented Apr 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isentropic commented Apr 26, 2021

Uh oh!

t-bltg commented Jul 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

codecov bot commented Dec 3, 2020 •

edited

Loading

isentropic commented Dec 4, 2020 •

edited

Loading

mbaz commented Dec 7, 2020 •

edited

Loading

VarLad commented Apr 25, 2021 •

edited

Loading