Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicodePlots: adjust layout width per column #3825

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Sep 17, 2021

  • Save some width (previously based on the largest column);
  • Add more supported attributes;
  • Move expensive tests (GR) at the end of the test suite.

@t-bltg t-bltg added enhancement improving existing functionality UnicodePlots labels Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #3825 (543bc66) into master (8573993) will increase coverage by 0.55%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3825      +/-   ##
==========================================
+ Coverage   63.01%   63.56%   +0.55%     
==========================================
  Files          28       28              
  Lines        7467     7463       -4     
==========================================
+ Hits         4705     4744      +39     
+ Misses       2762     2719      -43     
Impacted Files Coverage Δ
src/backends.jl 63.47% <ø> (ø)
src/backends/unicodeplots.jl 75.00% <81.25%> (+33.59%) ⬆️
src/plot.jl 66.20% <0.00%> (-4.83%) ⬇️
src/recipes.jl 59.71% <0.00%> (+0.21%) ⬆️
src/axes.jl 85.16% <0.00%> (+0.43%) ⬆️
src/output.jl 28.68% <0.00%> (+0.81%) ⬆️
src/colorbars.jl 92.72% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8573993...543bc66. Read the comment docs.

@t-bltg t-bltg force-pushed the up_width branch 22 times, most recently from 504faf3 to b891648 Compare September 17, 2021 19:16
@t-bltg t-bltg merged commit e2539a3 into JuliaPlots:master Sep 17, 2021
@t-bltg t-bltg deleted the up_width branch September 17, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing functionality UnicodePlots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant