-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contourplot
#199
Add contourplot
#199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 99.82% 99.74% -0.09%
==========================================
Files 23 24 +1
Lines 1164 1179 +15
==========================================
+ Hits 1162 1176 +14
- Misses 2 3 +1
Continue to review full report at Codecov.
|
6477963
to
f5264eb
Compare
69d5fd5
to
be6ccdb
Compare
bccc10c
to
c663f61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's almost impossible to review a 1000-lines PR with arbitrary unorganized commits and changes so I only left a few comments on changes I think should be reverted or separated. There are still many out there that I didn't comment.
It would be clearer to separate the visible
and blend
changes in separate PR(s), and then make this countourplot
PR an incremental feature on top of those PRs.
FWIW, for a clean git history: it makes no sense to record how you evolve into the current status, instead, it makes sense to record how functionalities are built step by step. Thus if you add something in the first commit and then immediately delete it in the second commit, it should be purged from the git history.
Thanks for taking the time to reviewing this. The workflow is difficult since on this branch, I needed some colormap changes, and the integration / testing within Plots.jl is best if I apply the changes in a single branch, but I hear the concern on reviewing my PRs. Developing using multiple branches is also hard to follow, and wastes development time. Sorry about the code style changes, bad practice indeed. I will rebase the whole thing and split PRs. |
Superseded by #204. |
contourplot
support (levels
,colormap
,colorbar
controls)Contour.jl
dependency for computing levels using theMarching_squares
algorithmblend
flag on all canvases to plot with/without color blend (avoid overlap issues on contour lines)visible
flag on all canvases: fix [FR] stand-alone version ofprintcolorbarrow
to draw a colorbar in isolation #169 as a side effectcividis
, and some ANSI256
subset colormaps.https://github.com/JuliaGeometry/Contour.jl is a small requirement, since it only depends on
StaticArrays
.See examples at JuliaPlots/Plots.jl#4031.
The new example from
README.md
now looks like this (gaussian profile):tiny benchmark