Skip to content

Conversation

@Cvikli
Copy link

@Cvikli Cvikli commented Feb 7, 2022

A raw VERY simple Vertical Unicode Histrogram plotting.

I see there are a lot of work needs to be done here. If someone could be a help for me, that would be much appreciated.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #221 (573aafd) into master (fecf19a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   99.91%   99.92%           
=======================================
  Files          25       26    +1     
  Lines        1211     1253   +42     
=======================================
+ Hits         1210     1252   +42     
  Misses          1        1           
Impacted Files Coverage Δ
src/interface/verticalhistogram.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecf19a...573aafd. Read the comment docs.

@t-bltg t-bltg changed the title vertical histrogram base vertical histogram base Feb 7, 2022
@t-bltg
Copy link
Member

t-bltg commented Feb 7, 2022

Thanks for this contribution.

I see there are a lot of work needs to be done here. If someone could be a help for me, that would be much appreciated.

As a maintainer of this repository, I can push in your fork, so I will make some changes now. Don't forget to synchronize you fork accordingly using git fetch && git pull before you need to make changes and push new commits.

Also note the README.md is auto-generated, you must edit docs/generate_docs.jl instead and follow https://github.com/JuliaPlots/UnicodePlots.jl#documentation-update (you can omit the bash gen_imgs.sh bit).

@t-bltg
Copy link
Member

t-bltg commented Feb 7, 2022

I see now that you are not using a canvas to draw vertical histograms. This won't work, and we request you to follow the internal structure of UnicodePlots.jl. In verticalhistogram you'd need to create a Plot object containing a canvas (see https://github.com/JuliaPlots/UnicodePlots.jl#low-level-interface) on which you can draw things. Calling show or display on that Plot object will print it to the screen (or a file), and this is what is missing for the tests to work. If you cannot reuse one of the existing canvases you'd have to create your own, but I don't think this is needed. I think you can hack src/graphics/bargraphics.jl to support a new function addcol! to add a column (vertical bar) to the canvas.

@t-bltg t-bltg force-pushed the VerticalUnicodeHistogram branch 3 times, most recently from b8c2e52 to 9b0a465 Compare February 7, 2022 08:32
@t-bltg t-bltg force-pushed the VerticalUnicodeHistogram branch from 9b0a465 to a4ecba6 Compare February 7, 2022 08:39
@Cvikli
Copy link
Author

Cvikli commented Feb 19, 2022

Hey, I checked what you are saying and maybe I could make a very basic implementation.
But sadly I won't have a single hour to finish it for 2 weeks. But after that I will try to come back!

@t-bltg
Copy link
Member

t-bltg commented Apr 26, 2022

Superseded by #250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants