MethodError with Makie's mesh

[mforets]

From this discourse question, which i can reproduce in my machine using Polyhedra v0.6.5, Makie v0.11.0:

using Makie, CDDLib, Polyhedra

v = convexhull([0, 0, 0]) + conichull([1, 0, 0], [0, 1, 0], [0, 0, 1])

p = polyhedron(v)

m = Polyhedra.Mesh(p)

Makie.mesh(m, color=:blue)

MethodError: no method matching iterate(::Polyhedra.Mesh{3,Rational{BigInt},DefaultPolyhedron{Rational{BigInt},Polyhedra.Intersection{Rational{BigInt},Array{Rational{BigInt},1},Int64},Polyhedra.Hull{Rational{BigInt},Array{Rational{BigInt},1},Int64}}})
Closest candidates are:
  iterate(!Matched::Core.SimpleVector) at essentials.jl:603
  iterate(!Matched::Core.SimpleVector, !Matched::Any) at essentials.jl:603
  iterate(!Matched::ExponentialBackOff) at error.jl:253
  ...

Stacktrace:
 [1] isempty(::Polyhedra.Mesh{3,Rational{BigInt},DefaultPolyhedron{Rational{BigInt},Polyhedra.Intersection{Rational{BigInt},Array{Rational{BigInt},1},Int64},Polyhedra.Hull{Rational{BigInt},Array{Rational{BigInt},1},Int64}}}) at ./essentials.jl:739
 [2] xyz_boundingbox(::Function, ::Polyhedra.Mesh{3,Rational{BigInt},DefaultPolyhedron{Rational{BigInt},Polyhedra.Intersection{Rational{BigInt},Array{Rational{BigInt},1},Int64},Polyhedra.Hull{Rational{BigInt},Array{Rational{BigInt},1},Int64}}}) at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/layouting/data_limits.jl:64
 [3] atomic_limits(::Mesh{...}) at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/layouting/data_limits.jl:17
 [4] data_limits at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/layouting/data_limits.jl:9 [inlined]
 [5] push!(::Scene, ::Mesh{...}) at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/scenes.jl:347
 [6] plot!(::Scene, ::Type{Mesh{...}}, ::Attributes, ::Tuple{Observable{Polyhedra.Mesh{3,Rational{BigInt},DefaultPolyhedron{Rational{BigInt},Polyhedra.Intersection{Rational{BigInt},Array{Rational{BigInt},1},Int64},Polyhedra.Hull{Rational{BigInt},Array{Rational{BigInt},1},Int64}}}}}, ::Observable{Tuple{Polyhedra.Mesh{3,Rational{BigInt},DefaultPolyhedron{Rational{BigInt},Polyhedra.Intersection{Rational{BigInt},Array{Rational{BigInt},1},Int64},Polyhedra.Hull{Rational{BigInt},Array{Rational{BigInt},1},Int64}}}}}) at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/interfaces.jl:653
 [7] plot!(::Scene, ::Type{Mesh{...}}, ::Attributes, ::Polyhedra.Mesh{3,Rational{BigInt},DefaultPolyhedron{Rational{BigInt},Polyhedra.Intersection{Rational{BigInt},Array{Rational{BigInt},1},Int64},Polyhedra.Hull{Rational{BigInt},Array{Rational{BigInt},1},Int64}}}; kw_attributes::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/interfaces.jl:580
 [8] plot! at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/interfaces.jl:549 [inlined]
 [9] mesh(::Polyhedra.Mesh{3,Rational{BigInt},DefaultPolyhedron{Rational{BigInt},Polyhedra.Intersection{Rational{BigInt},Array{Rational{BigInt},1},Int64},Polyhedra.Hull{Rational{BigInt},Array{Rational{BigInt},1},Int64}}}; attributes::Base.Iterators.Pairs{Symbol,Symbol,Tuple{Symbol},NamedTuple{(:color,),Tuple{Symbol}}}) at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/recipes.jl:15
 [10] top-level scope at In[9]:1

[schillic]

I think isempty(::Polyhedra.Mesh) is missing.

[mforets]

Indeed, i tried and defining Base.isempty(c::Polyhedra.Mesh) = isempty(c.polyhedron), fixes the problem in the OP. Then there is another error that comes from this line, as it calls this function. Maybe one should add a new dispatch on xyz_boundingbox when the second argument is a Polyhedra.Mesh, but i'm not sure what to use when the polyhedron is unbounded.

[blegat]

It may be because Makie is using GeometryBasics while Polyhedra only implements the GeometryTypes API. Does #212 fies your issue ?

[mforets]

Just tried bl/geometrybasics and the error in the OP is fixed 🎉

Now i'm getting an assertion error but it seems to be unrelated to Polyhedra.

julia> Makie.mesh(m, color=:blue)
[ Info: Precompiling PNGFiles [f57f5aa1-a3ce-4bc8-8ab9-96f992907883]
Error showing value of type Scene:
ERROR: AssertionError: status == GL_FRAMEBUFFER_COMPLETE
Stacktrace:
 [1] GLMakie.GLFramebuffer(::Tuple{Int64,Int64}) at /home/mforets/.julia/packages/GLMakie/wpJsD/src/glwindow.jl:188
 [2] GLMakie.Screen(; resolution::Tuple{Int64,Int64}, visible::Bool, title::String, kw_args::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /home/mforets/.julia/packages/GLMakie/wpJsD/src/screen.jl:316
 [3] Screen at /home/mforets/.julia/packages/GLMakie/wpJsD/src/screen.jl:275 [inlined]
 [4] global_gl_screen at /home/mforets/.julia/packages/GLMakie/wpJsD/src/screen.jl:346 [inlined]
 [5] global_gl_screen(::Tuple{Int64,Int64}, ::Bool, ::Int64) at /home/mforets/.julia/packages/GLMakie/wpJsD/src/screen.jl:356
 [6] global_gl_screen at /home/mforets/.julia/packages/GLMakie/wpJsD/src/screen.jl:355 [inlined]
 [7] backend_display at /home/mforets/.julia/packages/GLMakie/wpJsD/src/gl_backend.jl:57 [inlined]
 [8] display(::AbstractPlotting.PlotDisplay, ::Scene) at /home/mforets/.julia/packages/AbstractPlotting/q9DyS/src/display.jl:45
 [9] display(::Any) at ./multimedia.jl:323
 [10] #invokelatest#1 at ./essentials.jl:712 [inlined]
 [11] invokelatest at ./essentials.jl:711 [inlined]
 [12] print_response(::IO, ::Any, ::Bool, ::Bool, ::Any) at /home/mforets/Tools/julia-1.4.1-linux-x86_64/julia-1.4.1/share/julia/stdlib/v1.4/REPL/src/REPL.jl:161
 [13] print_response(::REPL.AbstractREPL, ::Any, ::Bool, ::Bool) at /home/mforets/Tools/julia-1.4.1-linux-x86_64/julia-1.4.1/share/julia/stdlib/v1.4/REPL/src/REPL.jl:146
 [14] (::REPL.var"#do_respond#38"{Bool,REPL.var"#48#57"{REPL.LineEditREPL,REPL.REPLHistoryProvider},REPL.LineEditREPL,REPL.LineEdit.Prompt})(::Any, ::Any, ::Any) at /home/mforets/Tools/julia-1.4.1-linux-x86_64/julia-1.4.1/share/julia/stdlib/v1.4/REPL/src/REPL.jl:729
 [15] #invokelatest#1 at ./essentials.jl:712 [inlined]
 [16] invokelatest at ./essentials.jl:711 [inlined]
 [17] run_interface(::REPL.Terminals.TextTerminal, ::REPL.LineEdit.ModalInterface, ::REPL.LineEdit.MIState) at /home/mforets/Tools/julia-1.4.1-linux-x86_64/julia-1.4.1/share/julia/stdlib/v1.4/REPL/src/LineEdit.jl:2354
 [18] run_frontend(::REPL.LineEditREPL, ::REPL.REPLBackendRef) at /home/mforets/Tools/julia-1.4.1-linux-x86_64/julia-1.4.1/share/julia/stdlib/v1.4/REPL/src/REPL.jl:1055
 [19] run_repl(::REPL.AbstractREPL, ::Any) at /home/mforets/Tools/julia-1.4.1-linux-x86_64/julia-1.4.1/share/julia/stdlib/v1.4/REPL/src/REPL.jl:206
 [20] (::Base.var"#764#766"{Bool,Bool,Bool,Bool})(::Module) at ./client.jl:383
 [21] #invokelatest#1 at ./essentials.jl:712 [inlined]
 [22] invokelatest at ./essentials.jl:711 [inlined]
 [23] run_main_repl(::Bool, ::Bool, ::Bool, ::Bool, ::Bool) at ./client.jl:367
 [24] exec_options(::Base.JLOptions) at ./client.jl:305
 [25] _start() at ./client.jl:484

[blegat]

Closed by #212