update functions to match the Seaborn API #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ming all of the functions at once
Contributor
Author
|
Sorry to bug you @stevengj but are you able to review and potentially merge this PR? Noticed that you're in the contributors. |
stevengj
reviewed
Apr 12, 2022
stevengj
reviewed
Apr 12, 2022
stevengj
reviewed
Apr 12, 2022
Member
|
(Probably |
stevengj
reviewed
Apr 16, 2022
stevengj
reviewed
Apr 16, 2022
stevengj
reviewed
Apr 16, 2022
stevengj
reviewed
Apr 16, 2022
stevengj
approved these changes
Apr 19, 2022
Member
|
Looks like an unrelated CI failure. |
Member
|
Whoops, I should have hit "squash and merge", didn't notice that this wasn't the default. 😠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current package is out of date and doesn't match the Seaborn API. Notably, it's missing some of the main plotting functions. I updated the module to define and export all of the functions in the API. I also simplified the metaprogramming approach to define all of the functions in the simple
format. I don't see why this would be a problem and everything seems to be working fine.