Vectorize and tests added. #37

Merged
merged 1 commit into from Jun 29, 2015

Conversation

Projects
None yet
2 participants
@amitjamadagni
Member

amitjamadagni commented Jun 24, 2015

No description provided.

@acroy

This comment has been minimized.

Show comment
Hide comment
@acroy

acroy Jun 24, 2015

Contributor

Seems some of the commits for dot and trace got mixed in.

You should also use similar_type vec to get the right constructor (see for instance /).

Contributor

acroy commented Jun 24, 2015

Seems some of the commits for dot and trace got mixed in.

You should also use similar_type vec to get the right constructor (see for instance /).

@acroy

This comment has been minimized.

Show comment
Hide comment
@acroy

acroy Jun 24, 2015

Contributor

Also: does vec work for arbitrary arrays or only for matrices?

Contributor

acroy commented Jun 24, 2015

Also: does vec work for arbitrary arrays or only for matrices?

@amitjamadagni

This comment has been minimized.

Show comment
Hide comment
@amitjamadagni

amitjamadagni Jun 24, 2015

Member

@acroy vec works for arbitrary arrays, I was of the thinking that if it is a vector it returns a vector, if it is a matrix then it flattens it, this might be directly useful in propagate methods for example here, for current_qustate and always returns a QuArray as it is always a one dimensional array.

Member

amitjamadagni commented Jun 24, 2015

@acroy vec works for arbitrary arrays, I was of the thinking that if it is a vector it returns a vector, if it is a matrix then it flattens it, this might be directly useful in propagate methods for example here, for current_qustate and always returns a QuArray as it is always a one dimensional array.

@acroy

This comment has been minimized.

Show comment
Hide comment
@acroy

acroy Jun 25, 2015

Contributor

Ok, I wasn't sure if it would work for all arrays. You also right about returning QuArray.

Contributor

acroy commented Jun 25, 2015

Ok, I wasn't sure if it would work for all arrays. You also right about returning QuArray.

acroy added a commit that referenced this pull request Jun 29, 2015

Merge pull request #37 from amitjamadagni/vec
Add vec for AbstractQuArrays plus tests.

@acroy acroy merged commit 6e2d893 into JuliaQuantum:master Jun 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@amitjamadagni amitjamadagni deleted the amitjamadagni:vec branch Jul 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment