Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1811 - Volume of a hyperrectangular set #1812

Merged
merged 12 commits into from Dec 11, 2019
Merged

#1811 - Volume of a hyperrectangular set #1812

merged 12 commits into from Dec 11, 2019

Conversation

@mforets
Copy link
Member

mforets commented Dec 3, 2019

Closes #1811.

  • add test
@mforets mforets force-pushed the mforets/1811 branch from a312167 to f917c7b Dec 10, 2019
@mforets mforets requested a review from schillic Dec 10, 2019
src/ConcreteOperations/volume.jl Outdated Show resolved Hide resolved
src/ConcreteOperations/volume.jl Outdated Show resolved Hide resolved
src/ConcreteOperations/volume.jl Outdated Show resolved Hide resolved
src/ConcreteOperations/volume.jl Outdated Show resolved Hide resolved
mforets and others added 4 commits Dec 10, 2019
Co-Authored-By: Christian Schilling <schillic@informatik.uni-freiburg.de>
Copy link
Member

schillic left a comment

So far we used the folder ConcreteOperations/ for binary functions that cannot be associated to one set type. I would rather distribute these functions to AbstractHyperrectangle.jl and BallInf.jl.

src/ConcreteOperations/volume.jl Outdated Show resolved Hide resolved
@mforets

This comment has been minimized.

Copy link
Member Author

mforets commented Dec 11, 2019

I would rather distribute these functions to AbstractHyperrectangle.jl and BallInf.jl.

Ok.

mforets added 2 commits Dec 11, 2019
src/Interfaces/AbstractHyperrectangle.jl Outdated Show resolved Hide resolved
src/Sets/BallInf.jl Show resolved Hide resolved
src/LazySets.jl Outdated Show resolved Hide resolved
mforets added 2 commits Dec 11, 2019
@mforets

This comment has been minimized.

Copy link
Member Author

mforets commented Dec 11, 2019

@schillic Thanks for your review!

As usual i will nevertheless wait for CI if something unexpected breaks...

@mforets mforets merged commit c53caa4 into master Dec 11, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mforets mforets deleted the mforets/1811 branch Dec 11, 2019
@mforets mforets mentioned this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.