Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#934 - Add exact projection method #935

Merged
merged 5 commits into from Dec 11, 2018
Merged

#934 - Add exact projection method #935

merged 5 commits into from Dec 11, 2018

Conversation

kpotomkin
Copy link
Collaborator

@kpotomkin kpotomkin commented Dec 5, 2018

Close #934
related #363

@kpotomkin kpotomkin changed the title Low-dimensional intersection [WIP]Low-dimensional intersection Dec 5, 2018
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully understand where you want to go. Maybe first explain that.

src/Approximations/decompositions.jl Outdated Show resolved Hide resolved
src/Approximations/decompositions.jl Outdated Show resolved Hide resolved
src/Approximations/decompositions.jl Outdated Show resolved Hide resolved
@schillic schillic changed the title [WIP]Low-dimensional intersection [WIP] #934 - Add exact projection method Dec 5, 2018
@schillic
Copy link
Member

schillic commented Dec 6, 2018

It would be good to add a small test in unit_decompose.jl (I guess just copy lines 21 and 22 and replace the set_type).

@mforets mforets changed the title [WIP] #934 - Add exact projection method #934 - Add exact projection method Dec 10, 2018
@kpotomkin kpotomkin merged commit 4a669f1 into master Dec 11, 2018
@schillic schillic mentioned this pull request Dec 11, 2018
@schillic schillic deleted the kostakoida/934 branch January 21, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants