Additional bounds on dependencies on old DataFrames.jl releases #10472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I understand that AutoMerge fails because this PR requires manual merging - right? |
bkamins
changed the title
Contributor
|
AutoMerge says "Neither a new package nor a new version", which is correct. I guess it's expected that this kind of PR needs manual reviewing. |
nalimilan
approved these changes
Mar 3, 2020
fredrikekre
reviewed
Mar 4, 2020
|
|
||
| ["0.18.2-0.19"] | ||
| PooledArrays = "0.5.0-*" | ||
| PooledArrays = "0.5.0" |
Member
There was a problem hiding this comment.
For future reference, this should be "0.5", otherwise it excludes e.g. 0.5.1 etc.
Contributor
Author
There was a problem hiding this comment.
Thank you - I was not sure about that when I made a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaData/DataFrames.jl#2137
The bounds are added in a way that the bounds are less or equal than the bounds on 0.20.2. In this way - if I understand things correctly - there should be no risk that an old version of DataFrames.jl will be installed instead of latest release because it has looser bounds.