Skip to content

Conversation

@JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Apr 28, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2020

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator/mjolnir/1154507a/v0.1.0 branch from bcf3a5e to 1a41314 Compare April 28, 2020 16:01
JuliaRegistrator referenced this pull request in FluxML/Mjolnir.jl Apr 28, 2020
@stevengj
Copy link
Contributor

It seems odd to register this package with no description at all of what it does?

@MikeInnes
Copy link
Contributor

I'm not sure if that's a question, but there is some description here which I'm in the process of turning into a readme. It's something of a base package for some other efforts like this and this, which have some more description of what they do.

@stevengj
Copy link
Contributor

stevengj commented May 1, 2020

Can you please write a few descriptive sentences in the README, and also update the github 1-line repo description, so that a mystery package with no description doesn't show up on pkg.julialang.org?

@DilumAluthge
Copy link
Member

@MikeInnes Can you retrigger Registrator? This will fix the merge conflict.

[noblock]

UUID: 1154507a-7ac2-44fe-9f15-34617bca9db5
Repo: https://github.com/MikeInnes/Mjolnir.jl.git
Tree: 650a14e0043aecadb904767e6fa0bf857a744439

Registrator tree SHA: nothing
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/mjolnir/1154507a/v0.1.0 branch from 1a41314 to 49536ae Compare May 12, 2020 14:35
JuliaRegistrator referenced this pull request in FluxML/Mjolnir.jl May 12, 2020
add some pure numeric functions
@MikeInnes
Copy link
Contributor

Readme is updated.

@stevengj
Copy link
Contributor

@MikeInnes, can you also update the "A little less conversation, a little more abstraction" one-line package description, since IIRC that is used for pkg.julialang.org?

@MikeInnes
Copy link
Contributor

done

@MikeInnes
Copy link
Contributor

By the way – might be useful if these rules were written down somewhere. Otherwise it seems a bit ad-hoc.

@DilumAluthge
Copy link
Member

@MikeInnes @stevengj Can I merge this?

@MikeInnes
Copy link
Contributor

Please do 👍

@DilumAluthge DilumAluthge merged commit f5ceb95 into master May 13, 2020
@DilumAluthge DilumAluthge deleted the registrator/mjolnir/1154507a/v0.1.0 branch May 13, 2020 15:17
@julia-tagbot
Copy link

julia-tagbot bot commented May 13, 2020

I've created release v0.1.0, here it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants