Skip to content

Conversation

@JuliaRegistrator
Copy link
Contributor

UUID: 7861f83d-ce22-4070-aa20-44578e274a9b
Repo: https://github.com/avigliotti/AD4SM.jl.git
Tree: ec1f0670f6d3115d0bc54789169f64fe601ff256

Registrator tree SHA: nothing
JuliaRegistrator referenced this pull request in avigliotti/AD4SM.jl May 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2020

Your new package pull request does not meet the following guidelines for auto-merging:

  • Name does not meet all of the following: starts with an uppercase letter, ASCII alphanumerics only, ends in a lowercase letter. Important note: It is okay to have a package name that ends in an uppercase letter. However, you will need to wait until a registry maintainer manually approves the name.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@avigliotti
Copy link

can I keep the name ending in capital letter or should I really change it?
I was not aware of this rule when I chose the name and to date I already mentioned the repo in a Mendely dataset, which was mentioned in a paper.

thanks,
A

@avigliotti
Copy link

[noblock] can I ask merging of this package is still under consideration?

@DilumAluthge DilumAluthge merged commit 1b39bff into master May 13, 2020
@DilumAluthge DilumAluthge deleted the registrator/ad4sm/7861f83d/v0.0.1 branch May 13, 2020 14:09
@avigliotti
Copy link

[noblock]
many thanks for the fast feedback!
can I ask if I need to take some steps or actions before the package appears in the registry (if it has been accepted for merging),

apologies for the question, I am quite new to the entire process

@DilumAluthge
Copy link
Member

It is in the registry now.

@avigliotti
Copy link

great! many thanks again!!
Andrea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants