Skip to content

Conversation

@JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented May 26, 2020

JuliaRegistrator referenced this pull request in JuliaGPU/CUDA.jl May 26, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2020

Your new package pull request does not meet the following guidelines for auto-merging:

  • Name does not meet all of the following: starts with an uppercase letter, ASCII alphanumerics only, not all letters are uppercase.**
  • Name is not at least five characters long

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@maleadt
Copy link
Contributor

maleadt commented May 26, 2020

Name does not meet all of the following: starts with an uppercase letter, ASCII alphanumerics only, not all letters are uppercase.**

Name is not at least five characters long

Can ignore these under "Packages that wrap external libraries or programs should be named after those libraries or programs."

I was not able to load the package (i.e. import CUDA failed). See the CI logs for details.

Ah yes this needs a GPUCompiler.jl tag. Will fix.

UUID: 052768ef-5323-5732-b1bb-66c8b64840ba
Repo: https://github.com/JuliaGPU/CUDA.jl.git
Tree: 3d247bd2260259f86853e52584169ddeca648ebc

Registrator tree SHA: 58e84c9733c0606ca53349dbce519209d8a8402b
@maleadt
Copy link
Contributor

maleadt commented May 26, 2020

OK, fixed, and the bot can now import the package. Should be good to go!

@vchuravy vchuravy merged commit 5edc30e into master May 26, 2020
@vchuravy vchuravy deleted the registrator/cuda/052768ef/v0.1.0 branch May 26, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants