Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version RoME: 0.3.4 #489

Merged
merged 1 commit into from
May 2, 2019
Merged

New version RoME: 0.3.4 #489

merged 1 commit into from
May 2, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented May 2, 2019 •
edited
Loading

Registering: RoME
Repository: https://github.com/JuliaRobotics/RoME.jl
Version: v0.3.4
Commit: 34733207a01dc07654e941efa919d2db569022a0
Proposed by: @dehann
Reviewed by: @dehann
Reference: JuliaRobotics/RoME.jl#173 (comment)

@JuliaRegistrator JuliaRegistrator mentioned this pull request May 2, 2019
Closed
fredrikekre
fredrikekre reviewed May 2, 2019
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to keep some compatibility constraints from previous releases.

R/RoME/Compat.toml
@@ -84,7 +84,7 @@ KernelDensityEstimate = "0.3.1-0"
["0.1.5-0.1.6"]
IncrementalInference = "0.3.6-0"

["0.1.6-0"]
["0.1.6-0.3.3"]
CoordinateTransformations = "0.5-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this constraint?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see new compat constraints starting from v0.3.4 -- added via https://github.com/JuliaRobotics/RoME.jl/pull/174/files

R/RoME/Compat.toml
["0.2-0.3.1"]
Graphs = "0.10.1-0"

["0.2-0.3.3"]
Distributions = "0.16.4-0.18"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above?

R/RoME/Compat.toml
["0.2.0"]
TransformUtils = "0.2.1-0"

["0.2.1-0"]
["0.2.1-0.3.3"]
TransformUtils = "0.2.2-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above?

R/RoME/Compat.toml
["0.3-0.3.1"]
IncrementalInference = "0.5-0"
KernelDensityEstimate = "0.4.3-0"

["0.3.2-0"]
["0.3-0.3.3"]
ApproxManifoldProducts = "0.0.3-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this too?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above?

R/RoME/Compat.toml
["0.3-0.3.3"]
ApproxManifoldProducts = "0.0.3-0"

["0.3.2-0.3.3"]
Graphs = "0.10.2-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above?

@dehann
Copy link

dehann commented May 2, 2019 •
edited
Loading

Hi, okay thanks will do, and want to get the compat definitions right! Just to be sure, I have two questions on Project.toml [compat] since JuliaRegistries/General is automatically generated from package info -- the author should not directly interact with this PR General. I don't have direct access to this PR that JuliaRegistrator created:

1.) In order for a package author to control version numbers of dependencies, we should populate Project.toml's [compat] field according to Pkg.jl docs?

2.) To fix the compat issues you mentioned above, I am starting to populate Project.toml as follows, however, there is now likely significant variation between what is in General and what I require. That is a failing on my part in not specifying [compat] sooner. I'm fighting through the Travis issues now to try rectify and sufficiently control the versioning of dependencies going forward. (I don't think I'm alone in this boat though).

PS, note that even Pkg.jl's Project.toml itself does not even specify a julia compat, as seems necessary... Maybe good to use that repo as an example?

@JuliaRegistrator
New version: RoME v0.3.4
dbafd75 
UUID: 91fb55c2-4c03-5a59-ba21-f4ea956187b8
Repo: https://github.com/JuliaRobotics/RoME.jl.git
Tree: 5f8b2e5cebf2fa4cee8f06c01f3de2b5e540a611

Registrator tree SHA: 6bfeeca034f599b4b2796adef9debf5b546b428f
@StefanKarpinski StefanKarpinski merged commit aae04a9 into master May 2, 2019
@julia-tagbot
Copy link

julia-tagbot bot commented May 2, 2019

I tried to create a release but ran into this error:

App is installed for user but the repository is not enabled

To retry, comment on this PR with the phrase TagBot tag.
cc: @christopher-dG

@StefanKarpinski StefanKarpinski deleted the register/RoME/v0.3.4 branch May 2, 2019 16:07
@JuliaRegistrator JuliaRegistrator mentioned this pull request Jun 24, 2019
Merged
@JuliaRegistrator JuliaRegistrator mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehann dehann dehann left review comments

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuliaRegistrator @dehann @fredrikekre @StefanKarpinski