Skip to content

Rename ParametrisedConvexApproximators to ParameterizedConvexApproximators #72031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Rename ParametrisedConvexApproximators to ParameterizedConvexApproximators #72031

wants to merge 3 commits into from

Conversation

@JinraeKim
Copy link

@JinraeKim JinraeKim commented Nov 10, 2022

as the name of the repo has been changed.

@JinraeKim
Copy link
Author

JinraeKim commented Nov 11, 2022

For someone seeing this:
I was following this instruction for renaming registered packages and I don't still know how it will end up being merged.

Is it ok to wait for a bit?

@JinraeKim JinraeKim mentioned this pull request Nov 16, 2022
Merged
1 task
@fredrikekre
Copy link
Member

fredrikekre commented Nov 17, 2022

What do you want to achieve here? There is no way to rename a package, you will have to register it as a completely new one. Would be pretty unfortunate to have ParametrisedConvexApproximators and ParameterizedConvexApproximators...

@JinraeKim
Copy link
Author

JinraeKim commented Nov 18, 2022 •
edited
Loading

What do you want to achieve here? There is no way to rename a package, you will have to register it as a completely new one. Would be pretty unfortunate to have ParametrisedConvexApproximators and ParameterizedConvexApproximators...

@fredrikekre You're right. As I mentioned in Julia discourse, I know this is kinda unnecessary work but I was trying to match the same with the reference paper.
If you think this is not worth it, I'll just close this PR. Please share your opinion.

Regardless of your opinion, I'll close this PR for now.

@JinraeKim JinraeKim closed this Nov 19, 2022
@JinraeKim JinraeKim mentioned this pull request Nov 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JinraeKim @fredrikekre