add description field #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2021
Member
|
Who is a good person to review this? |
DilumAluthge
approved these changes
Sep 2, 2021
Member
DilumAluthge
left a comment
DilumAluthge
left a comment
There was a problem hiding this comment.
This looks good to me, but it would be good to get a review from someone that is more familiar with the Registrator codebase.
nkottary
approved these changes
Sep 2, 2021
Member
|
Thank you @nkottary! Could you:
|
Member
|
The new version of Registrator v1.2.9 that has this change is not yet deployed. I am very busy this week. I will try to get this updated next week. |
Member
|
Just an update: We're working to get this to production. Might take a few more days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in JuliaRegistries/General#43776 it was suggested that it might be nice to have the repo description field in the PR comment. We could then grab it from the PR comment and send it downstream as well, e.g. to the Slack channel
#new-packages-feed, along with the release notes.From the WebUI or CommentBot we seem to have a
repoobject with this field, so we can get the description without an additional API call. However, I'm not sure if it is always populated or not; if it is not populated, then we'd need to make an API call to fill out the fields (repoin the comment bot to use GitHub.jl, orget_repoin the WebUI to use GitForge.jl).