Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Figure out how to automerge JLL packages #6

Closed
DilumAluthge opened this issue Oct 15, 2019 · 7 comments · Fixed by #153
Closed

TODO: Figure out how to automerge JLL packages #6

DilumAluthge opened this issue Oct 15, 2019 · 7 comments · Fixed by #153
Assignees

Comments

@DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member Author

@staticfloat

@DilumAluthge
Copy link
Member Author

@staticfloat So, I think I have an idea for how to automerge JLL packages. It will not require you to make any changes to your PR titles or your workflows in general.

I'll put a prototype together, will keep you posted.

@staticfloat
Copy link
Member

staticfloat commented Oct 28, 2019

I'm just about to get to this; (I've been chewing through other things over the past two weeks)

What do you think about this, it would be something much more similar to what Registrator creates:

  • All Yggdrasil builds will come in as a PR from a certain user (Perhaps @jlbuild, unless someone has a better username for me to use).
  • The title will be something like JLL Registration: $(name) v$(version)
  • The body will be something like:
* Registering JLL package $(name)
* Repository: https://github.com/JuliaBinaryWrappers/$(name)_jll.jl
* Version: v$(version)

Because we don't have JLL package restrictions on version numbers, it seems like we don't need to worry about new vs. updated packages, so we don't need to worry about different titles or anything like that.

@DilumAluthge
Copy link
Member Author

I think that the second line of the body should look like this, right? I.e. there is a .jl at the end of the URL?

* Repository: https://github.com/JuliaBinaryWrappers/$(name)_jll.jl

@fredrikekre
Copy link
Member

Why not just use registrator instead of reinventing the wheel?

@staticfloat
Copy link
Member

Internally, much of this is using Registrator.jl, but because the rules are different for JLL packages, (strange version numbers, shouldn't need to argue about naming, etc...) I think it makes sense for these to look differently.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Nov 16, 2019

@staticfloat pinged me on Slack that everything is set on their end, so we need to implement JLL automerging on our end.

Unfortunately I am swamped right now and won’t have the time to work on this anytime soon. @fredrikekre @staticfloat would either of you have time to add JLL automerging to RegistryCI? Basically need to check if it’s a JLL package, and if so exempt it from the version number and compat bounds requirements.

If not, I’ll try to work on it when I have the time.... realistically speaking, that might not be until next year 😬

SebastianM-C referenced this issue in SebastianM-C/RegistryCI.jl Sep 15, 2021
…_registryci-1.5.3

Update RegistryCI.jl by updating the .ci/Manifest.toml file (1.5.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants