From 21c4a9b03af141c7d4b0a0d2edca7b1cb6cd2a80 Mon Sep 17 00:00:00 2001 From: dehann Date: Mon, 23 Aug 2021 09:58:17 -0400 Subject: [PATCH 1/4] api instead setPointPartial! --- src/Deprecated.jl | 8 ++++++++ src/Interface.jl | 14 +++++++------- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/Deprecated.jl b/src/Deprecated.jl index 4a11d7f..f1f3045 100644 --- a/src/Deprecated.jl +++ b/src/Deprecated.jl @@ -4,6 +4,14 @@ ## Remove below before v0.6 ## ====================================================================================================== +@deprecate setPointsManiPartial!( Mdest::AbstractManifold, + dest, + Msrc::AbstractManifold, + src, + partial::AbstractVector{<:Integer}, + asPartial::Bool=true ) setPointsManiPartial!( Mdest, dest, Msrc, src, partial, asPartial=asPartial ) + + export productbelief """ diff --git a/src/Interface.jl b/src/Interface.jl index 6b98455..8e321dc 100644 --- a/src/Interface.jl +++ b/src/Interface.jl @@ -5,7 +5,7 @@ import Manifolds: identity_element export makeCoordsFromPoint, makePointFromCoords, getNumberCoords export identity_element -export setPointsManiPartial!, setPointsMani! +export setPointPartial!, setPointsMani! export replace # Deprecate in favor of TranslationGroup instead, also type piracy @@ -69,12 +69,12 @@ end # asPartial=true indicates that src coords are smaller than dest coords, and false implying src has dummy values in placeholder dimensions -function setPointsManiPartial!( Mdest::AbstractManifold, - dest, - Msrc::AbstractManifold, - src, - partial::AbstractVector{<:Integer}, - asPartial::Bool=true ) +function setPointPartial!(Mdest::AbstractManifold, + dest, + Msrc::AbstractManifold, + src, + partial::AbstractVector{<:Integer}, + asPartial::Bool=true ) # dest_ = AMP.makeCoordsFromPoint(Mdest,dest) From 64c2e08f8bf7a7807a9efa30b603743ec2d7325e Mon Sep 17 00:00:00 2001 From: dehann Date: Mon, 23 Aug 2021 14:43:14 -0400 Subject: [PATCH 2/4] fix depr --- src/Deprecated.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Deprecated.jl b/src/Deprecated.jl index f1f3045..48a18b2 100644 --- a/src/Deprecated.jl +++ b/src/Deprecated.jl @@ -9,7 +9,7 @@ Msrc::AbstractManifold, src, partial::AbstractVector{<:Integer}, - asPartial::Bool=true ) setPointsManiPartial!( Mdest, dest, Msrc, src, partial, asPartial=asPartial ) + asPartial::Bool=true ) setPointsManiPartial!( Mdest, dest, Msrc, src, partial, asPartial ) export productbelief From b3b70863ddd5df28e2d16c91d4a4599b7052473a Mon Sep 17 00:00:00 2001 From: dehann Date: Mon, 23 Aug 2021 14:48:01 -0400 Subject: [PATCH 3/4] fix depr --- src/Deprecated.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Deprecated.jl b/src/Deprecated.jl index 48a18b2..66260c3 100644 --- a/src/Deprecated.jl +++ b/src/Deprecated.jl @@ -9,7 +9,7 @@ Msrc::AbstractManifold, src, partial::AbstractVector{<:Integer}, - asPartial::Bool=true ) setPointsManiPartial!( Mdest, dest, Msrc, src, partial, asPartial ) + asPartial::Bool=true ) setPointPartial!( Mdest, dest, Msrc, src, partial, asPartial ) export productbelief From 15546501f6670f1607cf1d4b8bd34bbf32f95e7c Mon Sep 17 00:00:00 2001 From: dehann Date: Mon, 23 Aug 2021 14:49:18 -0400 Subject: [PATCH 4/4] fix --- src/services/ManifoldKernelDensity.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/ManifoldKernelDensity.jl b/src/services/ManifoldKernelDensity.jl index c34bd44..5855778 100644 --- a/src/services/ManifoldKernelDensity.jl +++ b/src/services/ManifoldKernelDensity.jl @@ -182,7 +182,7 @@ function antimarginal(newM::AbstractManifold, pts = getPoints(mkd, false) nPts = Vector{typeof(u0)}(undef, length(pts)) for (i,pt) in enumerate(pts) - nPts[i] = setPointsManiPartial!(newM, deepcopy(u0), mkd.manifold, pt, newpartial) + nPts[i] = setPointPartial!(newM, deepcopy(u0), mkd.manifold, pt, newpartial) end # also update metadata elements