Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CSM files to aid consolidation and understanding #934

Closed
dehann opened this issue Oct 1, 2020 · 0 comments · Fixed by #939
Closed

Rename CSM files to aid consolidation and understanding #934

dehann opened this issue Oct 1, 2020 · 0 comments · Fixed by #939
Assignees
@Affie
Labels
clique state machine refactoring
Projects
Roadmap to V1.0 Tree and belief messages consolidation
Milestone
v0.16.0

Comments

@dehann
Copy link
Member

dehann commented Oct 1, 2020 •
edited

Following from discussion in #855 , lets rename files:

  • CliqueStateMachine.jl --> CliqueStateMachine_fetch.jl
  • CliqueStateMachine_Parametric.jl --> CliqueStateMachine_take.jl

All agnostic CSM state_functions should be moved into CSMCommon_Consolidate.jl.

Can only do after current #754 is closed

This should help in the process to reduce the differences between fetch and take models, also help break the stigma of parametric vs nonparametric.
@dehann dehann added this to the v0.16.0 milestone Oct 1, 2020
@dehann dehann added this to Improvements in Roadmap to V1.0 via automation Oct 1, 2020
@dehann dehann added this to To do in Tree and belief messages consolidation via automation Oct 1, 2020
Affie added a commit that referenced this issue Oct 2, 2020
@Affie
rename CliqStateMachine.jl and CliqStateMachine_Parametric.jl
d5a2a8c 
close #934
@Affie Affie mentioned this issue Oct 2, 2020
Merged
@Affie Affie closed this as completed in #939 Oct 2, 2020
Roadmap to V1.0 automation moved this from Improvements to Completed Oct 2, 2020
Tree and belief messages consolidation automation moved this from To do to Done Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Affie Affie

Labels
clique state machine refactoring
Projects
Roadmap to V1.0
  
Completed
Tree and belief messages consolidation
  
Done
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

Rename CliqStateMachine.jl and CliqStateMachine_Parametric.jl JuliaRobotics/IncrementalInference.jl
2 participants
@dehann @Affie