Skip to content

Add support for SingleVariable objective #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2020
Merged

Add support for SingleVariable objective #47

merged 3 commits into from
May 1, 2020

Conversation

@amontoison
Copy link
Member

@amontoison amontoison commented Apr 13, 2020 •
edited
Loading

close #49

Objective like min(t) or max(x[i]) are SingleVariable objective and not ScalarAffineFunction or
ScalarQuadraticFunction.

@coveralls
Copy link

coveralls commented Apr 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 99.16% when pulling 5332b11 on amontoison:SingleVariable into db82303 on JuliaSmoothOptimizers:master.

abelsiqueira
abelsiqueira reviewed Apr 29, 2020
View reviewed changes
test/nlp_problems/linsv.jl
@objective(nlp, Min, x[1])

return nlp
end
Copy link
Member

@abelsiqueira abelsiqueira Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an autodiff problem and run the consistency checks?

Copy link
Member Author

@amontoison amontoison Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -> JuliaSmoothOptimizers/NLPModels.jl#283

Copy link
Member

@abelsiqueira abelsiqueira May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JuliaRegistries/General#13978

@abelsiqueira abelsiqueira requested a review from dpo May 1, 2020 18:00
@abelsiqueira abelsiqueira merged commit dce87d7 into JuliaSmoothOptimizers:master May 1, 2020
@abelsiqueira
Copy link
Member

abelsiqueira commented May 1, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abelsiqueira abelsiqueira abelsiqueira left review comments

@dpo dpo dpo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linear / quadratic models

4 participants

@amontoison @coveralls @abelsiqueira @dpo