Fix some errors in demos #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Here are the |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 59.34% 59.34%
=======================================
Files 11 11
Lines 1225 1225
=======================================
Hits 727 727
Misses 498 498 ☔ View full report in Codecov by Sentry. |
dpo
reviewed
Jun 3, 2023
| reset!(f) | ||
| TR_out = TR(f, h, χ, options, selected = selected) | ||
| plot_nnmf(TR_out, Avec, m, n, k, "tr-r2-$suffix") | ||
|
|
Member
There was a problem hiding this comment.
What is the reason for removing these lines?
Member
Author
There was a problem hiding this comment.
They are already written a few line above. I must have done a wrong copy/paste when adding this demo.
dpo
approved these changes
Jun 4, 2023
Contributor
|
Here are the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.