Bug fix in PG alg for options and iteration count #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs#109 Fixed tolerance ϵ to ϵa for absolute tolerance, as is already used in DescentOptions Fixed bug where the code incremeents k twice in each step
AHsu98
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 59.26% 59.38% +0.11%
==========================================
Files 11 11
Lines 1225 1226 +1
==========================================
+ Hits 726 728 +2
+ Misses 499 498 -1
☔ View full report in Codecov by Sentry. |
Member
|
Thanks. PG isn’t even tested in the unit tests. I recommend using R2 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed tolerance ϵ to ϵa for absolute tolerance, as is already used in DescentOptions
Fixed bug where the code incremeents k twice in each step