Skip to content

Conversation

@MaxenceGollier
Copy link
Collaborator

@MaxenceGollier MaxenceGollier requested a review from dpo March 25, 2025 16:19
@MaxenceGollier
Copy link
Collaborator Author

Can we merge this now ? @dpo

@MaxenceGollier MaxenceGollier requested a review from dpo April 7, 2025 20:11
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dpo
Copy link
Member

dpo commented Apr 9, 2025

@MaxenceGollier Please rebase.

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.45%. Comparing base (e0f214d) to head (fd45839).
Report is 81 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   61.53%   58.45%   -3.09%     
==========================================
  Files          11       14       +3     
  Lines        1292     1834     +542     
==========================================
+ Hits          795     1072     +277     
- Misses        497      762     +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpo dpo merged commit f063735 into JuliaSmoothOptimizers:master Apr 9, 2025
13 of 14 checks passed
@dpo
Copy link
Member

dpo commented Apr 9, 2025

Thank you.

@MaxenceGollier MaxenceGollier deleted the StepRegExecutionStats branch April 9, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants