Skip to content

Conversation

@stevengj
Copy link
Contributor

@stevengj stevengj commented Aug 30, 2024

This PR marks the MatrixReshaped type itself as deprecated, not just its constructor. That should prevent it from being displayed as the type name in Julia. (See this discourse post.)

For example:

julia> struct Bar{T}; x::T; end

julia> const Foo = Bar{Int}
Foo (alias for Bar{Int64})

julia> Foo(3) # displays alias Foo instead of Bar{Int}
Foo(3)

julia> Base.deprecate(Main, :Foo)

julia> Foo(3) # no longer displays the deprecated Foo type alias
Bar{Int64}(3)

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (e1340f0) to head (3ffdf43).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1893   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files         144      144           
  Lines        8666     8666           
=======================================
  Hits         7452     7452           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion devmotion merged commit b219803 into JuliaStats:master Sep 2, 2024
@stevengj stevengj deleted the patch-2 branch September 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants