Skip to content

Bump dependencies #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 18, 2020
Merged

Bump dependencies #392

merged 5 commits into from
Dec 18, 2020

Conversation

@nalimilan
Copy link
Member

@nalimilan nalimilan commented Dec 11, 2020

Fixes #388.

This was referenced Dec 11, 2020
Closed
Closed
@codecov-io
Copy link

codecov-io commented Dec 11, 2020 •
edited
Loading

Codecov Report

Merging #392 (adb0589) into master (048b8ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files           7        7           
  Lines         685      685           
=======================================
  Hits          539      539           
  Misses        146      146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048b8ac...adb0589. Read the comment docs.

@nalimilan nalimilan changed the title Bump SpecialFunctions and DataFrames Bump SpecialFunctions, DataFrames and CategoricalArrays Dec 11, 2020
@nalimilan nalimilan changed the title Bump SpecialFunctions, DataFrames and CategoricalArrays Bump dependencies Dec 11, 2020
@nalimilan
Copy link
Member Author

nalimilan commented Dec 11, 2020

OK, now CI really used the latest version of dependencies.

kleinschmidt
kleinschmidt approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@kleinschmidt kleinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few deprecations came up in the tests, just minor stuff but maybe worth fixing those here too?

https://github.com/JuliaStats/GLM.jl/pull/392/checks?check_run_id=1536514296#step:7:160

https://github.com/JuliaStats/GLM.jl/pull/392/checks?check_run_id=1536514296#step:7:117

@nalimilan
Copy link
Member Author

nalimilan commented Dec 18, 2020

Argh, I accidentally edited master instead of this PR. Hopefully everything will pass after merging.

@nalimilan nalimilan merged commit 4cbb2ae into master Dec 18, 2020
@nalimilan nalimilan deleted the nl/deps branch December 18, 2020 09:50
This was referenced Dec 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kleinschmidt kleinschmidt kleinschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump DataFrames.jl to allow 0.22

4 participants

@nalimilan @codecov-io @kleinschmidt