warning for GLMM with dispersion parameter #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 94.86% 94.97% +0.11%
==========================================
Files 23 23
Lines 1576 1593 +17
==========================================
+ Hits 1495 1513 +18
+ Misses 81 80 -1
Continue to review full report at Codecov.
|
dmbates
reviewed
Sep 22, 2020
src/generalizedlinearmixedmodel.jl
Outdated
| throw(ArgumentError("use LinearMixedModel for Normal distribution with IdentityLink")) | ||
|
|
||
| if !any(isa(d, dist) for dist in (Bernoulli, Binomial, Poisson)) | ||
| @warn """Results for families with a dispersion parameter are known to be inaccurate. |
Collaborator
There was a problem hiding this comment.
I might change that to "Results for families with a dispersion parameter are not reliable. It is best to avoid trying to fit such models in MixedModels until the authors get a better understanding of those cases."
dmbates
approved these changes
Sep 23, 2020
palday
added a commit
that referenced
this pull request
Oct 2, 2020
…ith dispersion parameter(cherry picked from commit 66b8863)
palday
added a commit
that referenced
this pull request
Oct 2, 2020
* warning for GLMM with dispersion parameter (#373)* warning for GLMM with dispersion parameter(cherry picked from commit 66b8863) * correct coeftable for GLMMs, add tests (#308) * Move methods for abstract MixedModel struct to separate file. (cherry picked from commit 5fb6f65) * chang CoefTable column names to match GLM.jl * ranef method for GLMM (#336) (cherry picked from commit 753aa6f) * make (1|x) + (y|x) equivalent to (1|x) + (0+y|x) (#338) * fix error with (1|x) + (y|x) * fix typo (cherry picked from commit 20c83ef) * update ranef docstring Co-authored-by: Douglas Bates <dmbates@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372.
Is the warning message okay?