Skip to content

/MultivariateStats.jl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change warn to at-warn for Julia 1.0 compatibility #91

Closed
nico202 opened this issue Apr 11, 2019 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nico202 @ararslan
@nico202
Copy link
Contributor

commented Apr 11, 2019 •
edited

There are a couple of warn that should be @ warn like here:

MultivariateStats.jl/src/cmds.jl

Line 92 in ca576a4

dowarn && warn("Gramian has only $(i-1) positive eigenvalue(s)")

and

MultivariateStats.jl/src/cmds.jl

Line 105 in ca576a4

dowarn && warn("The last eigenpair is degenerate with $(nevals-1) others; $nevalsmore were ignored. Answer is not unique")

@ararslan ararslan changed the title warn broken on julia 1.0 Change warn to at-warn for Julia 1.0 compatibility Apr 11, 2019

@ararslan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 11, 2019

Would you be willing to submit a PR for this?
@nico202

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Apr 23, 2019

Sorry I missed the notification. Sure

@nico202 nico202 referenced this issue Apr 23, 2019

Merged

cmds: change warn to at-warn for Julia 1.0+ compatibility #92

ararslan added a commit that referenced this issue Apr 23, 2019

@nico202 @ararslan
cmds: change warn to at-warn for Julia 1.0+ compatibility (#92) 
Fix issue #91
Loading status checks…
c365814

@nico202 nico202 closed this Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.