Fix #121 and add dependency on IrrationalConstants (extension of #118) #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
changed the title
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 28.72% 28.91% +0.19%
==========================================
Files 11 11
Lines 369 370 +1
==========================================
+ Hits 106 107 +1
Misses 263 263
Continue to review full report at Codecov.
|
Member
Author
|
@KristofferC Maybe support for LogExpFunctions 0.2 should be removed since it defines some of the log constants that are moved to IrrationalConstants? However, they are not imported or exported anymore and I don't get any warnings if I load StatsFuns (this PR) based on LogExpFunctions 0.2. |
Contributor
Yes, that should be done. |
tpapp
approved these changes
Aug 13, 2021
Co-authored-by: Tamas K. Papp <tkpapp@gmail.com>
Member
|
👍 |
This was referenced Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #121. It removes the constants from StatsFuns and instead reexports the statistical constants defined in IrrationalConstants. Moreover, it adds support for LogExpFunctions 0.3 (which was not part of #118). Additionally, it fixes a test error that showed up in #118.