From 2856184300d64115a5d9705d8191c24497969569 Mon Sep 17 00:00:00 2001 From: Dave Kleinschmidt Date: Wed, 29 Nov 2017 23:18:01 -0500 Subject: [PATCH 1/2] import coefnames --- src/StatsModels.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/StatsModels.jl b/src/StatsModels.jl index 8166e1e8..c1a355e8 100644 --- a/src/StatsModels.jl +++ b/src/StatsModels.jl @@ -8,6 +8,7 @@ using StatsBase using Missings using CategoricalArrays +import StatsBase: coefnames export @formula, Formula, From e553b568213e64dfff27dc90a764e41ad7f8a9fb Mon Sep 17 00:00:00 2001 From: Dave Kleinschmidt Date: Wed, 29 Nov 2017 23:19:14 -0500 Subject: [PATCH 2/2] actually just specify it the one place it's used --- src/StatsModels.jl | 2 -- src/modelframe.jl | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/StatsModels.jl b/src/StatsModels.jl index c1a355e8..f1a55642 100644 --- a/src/StatsModels.jl +++ b/src/StatsModels.jl @@ -8,8 +8,6 @@ using StatsBase using Missings using CategoricalArrays -import StatsBase: coefnames - export @formula, Formula, ModelFrame, diff --git a/src/modelframe.jl b/src/modelframe.jl index be4f9ef7..e69a2014 100644 --- a/src/modelframe.jl +++ b/src/modelframe.jl @@ -223,7 +223,7 @@ end Returns a vector of coefficient names constructed from the Terms member and the types of the evaluation columns. """ -function coefnames(mf::ModelFrame) +function StatsBase.coefnames(mf::ModelFrame) terms = droprandomeffects(dropresponse!(mf.terms)) ## strategy mirrors ModelMatrx constructor: