Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add `obsdim` kwarg to `modelcols` #115

Open
oxinabox opened this issue Jun 13, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@oxinabox
Copy link
Contributor

commented Jun 13, 2019

Some packages like observations to be in the first dimension
others in the last dimension

e.g.

First (rows as obs)

  • GLM.jl
  • LIBSVM.jl
  • LIBLINEAR.jl
  • DecisonTrees.jl

Last (columns as obs)

  • Flux.jl
  • Distributions.jl
  • Distances.jl (and thus MultivariateStats.jl and NearestNeighbours.jl)

The only real consistancy is there is no consistancy.
There are performance implications that change depending on what operations you are doing.

modelcols should thus take a kwarg to specify which it is;
and transpose the result as needed.

If we do this we might want to rename it to modelfeatures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.