Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Missings and use Base.nonmissingtype #151

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Conversation

kleinschmidt
Copy link
Member

Fixes #150

Also updates the travis script to test on 1.0, 1.2, 1.3, and nightly, dropping
1.1; also don't test on OSX anymore

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #151 into master will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #151      +/-   ##
=========================================
- Coverage   84.04%   83.6%   -0.44%     
=========================================
  Files           9       9              
  Lines         495     494       -1     
=========================================
- Hits          416     413       -3     
- Misses         79      81       +2
Impacted Files Coverage Δ
src/modelframe.jl 88.63% <ø> (ø) ⬆️
src/StatsModels.jl 100% <ø> (ø) ⬆️
src/terms.jl 84.34% <0%> (-1%) ⬇️
src/schema.jl 80.9% <0%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91efc7a...1494784. Read the comment docs.

@kleinschmidt kleinschmidt merged commit d03b5c2 into master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated Missings.T
2 participants