-
Notifications
You must be signed in to change notification settings - Fork 34
Add string method for term
#190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This simplifies programmatically constructing formulas from DataFrames columns now that `names()` returns strings.
|
Looks great. Can you add something to the docs/src/formula.md file too? |
|
Oh and add some tests! |
Ah right I was wondering about that - I thought the |
|
Unfortunately not (you can see where they run in the documentation job below...rather than the travis job). We currently duplicate many of them in the actual tests. They're mostly used to make sure there aren't broken examples in the docs :) |
|
Pretty bare bones but I think this might do the trick? |
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
|
LGTM! Last thing: bump the patch version in Project.toml? Thanks for the contribution! |
+ related docs changes and tests
As discussed on Slack, this makes it easier to create
Termobjects fromDataFramecolumns, asnames(df)now returns strings.