Skip to content

Conversation

@nilshg
Copy link
Contributor

@nilshg nilshg commented Aug 29, 2020

As discussed on Slack, this makes it easier to create Term objects from DataFrame columns, as names(df) now returns strings.

nilshg added 2 commits August 29, 2020 18:25
This simplifies programmatically constructing formulas from DataFrames columns now that `names()` returns strings.
@kleinschmidt
Copy link
Member

Looks great. Can you add something to the docs/src/formula.md file too? term is described there as well.

@kleinschmidt
Copy link
Member

Oh and add some tests!

@nilshg
Copy link
Contributor Author

nilshg commented Aug 29, 2020

Oh and add some tests!

Ah right I was wondering about that - I thought the jldoctest stuff is a test, so that changing the example in the docstring to include a string would be the test. Is that not actually the case or is it just that doctests are additional to normal tests, not a replacement?

@kleinschmidt
Copy link
Member

Unfortunately not (you can see where they run in the documentation job below...rather than the travis job). We currently duplicate many of them in the actual tests. They're mostly used to make sure there aren't broken examples in the docs :)

@nilshg
Copy link
Contributor Author

nilshg commented Aug 31, 2020

Pretty bare bones but I think this might do the trick?

nilshg and others added 2 commits August 31, 2020 21:24
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
@kleinschmidt
Copy link
Member

LGTM! Last thing: bump the patch version in Project.toml? Thanks for the contribution!

+ related docs changes and tests
@kleinschmidt kleinschmidt merged commit a966c65 into JuliaStats:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants