Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine: support Period for collapse #500

Merged
merged 3 commits into from Jul 8, 2021
Merged

combine: support Period for collapse #500

merged 3 commits into from Jul 8, 2021

Conversation

iblislin
Copy link
Collaborator

@iblislin iblislin commented Jul 6, 2021

  • improve memory consumption and performance
  • type promotion

close #498

- improve memory consumption and performance
- type promotion
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #500 (d5c356e) into master (bb7eec3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   88.03%   88.06%   +0.03%     
==========================================
  Files          12       12              
  Lines         702      704       +2     
==========================================
+ Hits          618      620       +2     
  Misses         84       84              
Impacted Files Coverage Δ
src/combine.jl 96.84% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7eec3...d5c356e. Read the comment docs.

@iblislin
Copy link
Collaborator Author

iblislin commented Jul 7, 2021

@clouds56 could you try this PR out?

@iblislin
Copy link
Collaborator Author

iblislin commented Jul 8, 2021

I'm going to merge this PR if no objection

@iblislin iblislin merged commit 9dd2355 into master Jul 8, 2021
@iblislin iblislin deleted the ib/collapse-period branch July 8, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapse (document) does not work correctly
2 participants