Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns dramatically wrong results (from Formatting.jl) #63

Closed
goerz opened this issue Feb 2, 2023 · 2 comments
Closed

Returns dramatically wrong results (from Formatting.jl) #63

goerz opened this issue Feb 2, 2023 · 2 comments

Comments

@goerz
Copy link

goerz commented Feb 2, 2023

It seems that this port is bringing over the following rather serious correctness bug from Formatting.jl:

JuliaIO/Formatting.jl#108

julia> using Format
julia> fspec = FormatSpec(".1e")
julia> printfmt(fspec, 0.0003)
2.10e-04
@jariji
Copy link

jariji commented Jul 24, 2023

Any chance this could be addressed?

@ScottPJones
Copy link
Member

Yes - I intend to do a full rewrite of some of the formatting code (which currently has 3 different formatting paths!), to be based on the code that is already based on Ryu, which will address this issue.

ScottPJones added a commit that referenced this issue Jan 30, 2024
@ScottPJones
Fix issue #63 - incorrect results with python format e
d116e94
ScottPJones added a commit that referenced this issue Jan 30, 2024
@ScottPJones
Merge pull request #65 from JuliaString/spj/fixtypemin
f4c9b77 
Add support for Python ^ (center justification), fix issue #63, and Formatting.jl#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@goerz @ScottPJones @jariji