RFC: allow string interpolation in L"..." #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
commented
Sep 20, 2020
stevengj
reviewed
Sep 20, 2020
stevengj
reviewed
Sep 20, 2020
Contributor
Author
|
Ok, I refactored some of the logic a bit and fixed some bugs I discovered, but I think I fixed all of them now. I hope it's okay, I added some doctests and included them in the tests, but I was afraid that if we didn't test those, they would bitrot. I also bumped the minor version, but feel free to revert that if you want to do something else for releases. |
Member
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
%$for interpolation, as proposed by you in #27, which seems fine to me, but I'm happy to change it for something else. Still need to add docs and tests, but wanted to get a go-ahead on this approach first.fixes #27