Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add where syntax to rules #329

Merged
merged 3 commits into from Aug 9, 2021
Merged

Add where syntax to rules #329

merged 3 commits into from Aug 9, 2021

Conversation

rikhuijzer
Copy link
Contributor

Closes #322.

@shashi, I think that it would be good to also test a more complicated rule with the predicate, but I couldn't get it to work. Could you either add it to the PR or give a suggestion?

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #329 (78e5e2c) into master (aee8482) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   83.89%   84.00%   +0.10%     
==========================================
  Files          12       12              
  Lines        1217     1225       +8     
==========================================
+ Hits         1021     1029       +8     
  Misses        196      196              
Impacted Files Coverage Δ
src/rule.jl 86.77% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee8482...78e5e2c. Read the comment docs.

@rikhuijzer rikhuijzer mentioned this pull request Aug 8, 2021
src/rule.jl Show resolved Hide resolved
src/rule.jl Show resolved Hide resolved
src/rule.jl Show resolved Hide resolved
@shashi shashi merged commit f4ba92e into JuliaSymbolics:master Aug 9, 2021
@rikhuijzer
Copy link
Contributor Author

Hey xD I'm still processing the very nice tip to use :($x ? $y : nothing) instead of Meta.parse

@shashi
Copy link
Member

shashi commented Aug 9, 2021

Oh no, I thought it's only in the tests. Sorry, would you mind opening another PR?

@rikhuijzer
Copy link
Contributor Author

Oh no, I thought it's only in the tests. Sorry, would you mind opening another PR?

Np. Will be there in a few mins.

@rikhuijzer rikhuijzer deleted the where branch August 9, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predicate over multiple slot variables
4 participants