fix: avoid ConstructionBase.setproperties ambiguity
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
|
This change also broke old SymbolicUtils versions such as eg. 1.5.1 or 1.7.0 (which I have to keep using for now due to compatibility with MTK v8: #595). Can we backport this fix to older versions? |
Member
|
Yes we can backport. Just to v2? |
Contributor
|
Backporting to v1 is necessary for MTK 8. |
ChrisRackauckas
added a commit
that referenced
this pull request
Aug 19, 2024
fix: avoid `ConstructionBase.setproperties` ambiguity
ChrisRackauckas
added a commit
that referenced
this pull request
Aug 19, 2024
fix: avoid `ConstructionBase.setproperties` ambiguity
ChrisRackauckas
added a commit
that referenced
this pull request
Aug 19, 2024
fix: avoid `ConstructionBase.setproperties` ambiguity
Member
|
Backported all the way to v0.19 |
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this ambiguity. The
ConstructionBasedocs explicitly recommend adding a method tosetproperties(setproperties_objectis undocumented internals) and type-annotatingpatch::NamedTuple.