Fix for complex powers of symbolics#719
Closed
karlwessel wants to merge 0 commit intoJuliaSymbolics:masterfrom
Closed
Fix for complex powers of symbolics#719karlwessel wants to merge 0 commit intoJuliaSymbolics:masterfrom
karlwessel wants to merge 0 commit intoJuliaSymbolics:masterfrom
Conversation
Contributor
Author
|
Anything preventing this from merging? |
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Contributor
Author
|
Failing integration test seems unrelated. And I am not sure why some of the benchmarks are much slower with this PR, can't imagine that this change should have much of an effect. |
Member
|
It's weird but also very reproducible and in some cases very significant. Could you rebase to make sure it isn't due to some outdated changes? |
Contributor
Author
|
Sorry, something went wrong here. I rebased locally and then force pushed the changes. Somehow that closed the pull request automatically... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #717