Precompile symbolic_solve in SymbolicsGroebnerExt.jl
#1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
===========================================
+ Coverage 8.30% 79.81% +71.50%
===========================================
Files 46 46
Lines 4549 4622 +73
===========================================
+ Hits 378 3689 +3311
+ Misses 4171 933 -3238 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
symbolic_solve, which uses the Groebner.jl package extension, takes about 20 seconds to run for the first time on my laptop for very simple linear equations. I've added precompilation statements (using PrecompileTools) in the fileSymbolicsGroebnerExt.jlto significantly reduce the latency for users, following some discussions on Discourse:https://discourse.julialang.org/t/new-symbolic-solver-for-symbolics-jl/