Skip to content

Precompile symbolic_solve in SymbolicsGroebnerExt.jl #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Precompile symbolic_solve in SymbolicsGroebnerExt.jl #1233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea76c9
In SymbolicsGroebnerExt.jl, precompile `symbolic_solve` to improve us…
zengmao Aug 24, 2024
13d46cd
Update SymbolicsGroebnerExt.jl
ChrisRackauckas Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions ext/SymbolicsGroebnerExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,9 @@ module SymbolicsGroebnerExt

using Groebner
const Nemo = Groebner.Nemo

if isdefined(Base, :get_extension)
using Symbolics
using Symbolics: Num, symtype
else
using ..Symbolics
using ..Symbolics: Num, symtype
end
using Symbolics
using Symbolics: Num, symtype
import Symbolics.PrecompileTools

"""
groebner_basis(polynomials; kwargs...)
Expand Down Expand Up @@ -307,4 +302,20 @@ function Symbolics.solve_multivar(eqs::Vector, vars::Vector{Num}; dropmultiplici
sol
end

PrecompileTools.@setup_workload begin
@variables a b c x y z
equation1 = a*log(x)^b + c ~ 0
equation_actually_polynomial = sin(x^2 +1)^2 + sin(x^2 + 1) + 3
simple_linear_equations = [x - y, y + 2z]
expr_with_params = expand((x + b)*(x^2 + 2x + 1)*(x^2 - a))
equations_intersect_sphere_line = [x^2 + y^2 + z^2 - 9, x - 2y + 3, y - z]
PrecompileTools.@compile_workload begin
symbolic_solve(equation1, x)
symbolic_solve(equation_actually_polynomial)
symbolic_solve(simple_linear_equations, [x, y])
symbolic_solve(expr_with_params, x, dropmultiplicity=false)
symbolic_solve(equations_intersect_sphere_line, [x, y, z])
end
end

end # module