Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upuse DataDeps.jl for downloading #8
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This looks good to me. But, I'm in the make-or-break stage of my dissertation, so my review is cursory at best. @oxinabox you seem to be either the main or one of the main organizers for JuliaText. If you have pull rights, I think you're in a better position than I am to make these important decisions. |
This comment has been minimized.
This comment has been minimized.
Fair enough, |
This comment has been minimized.
This comment has been minimized.
(Just, FYI: @oxinabox. I should be wrapping up sometime in June / July. After which, I plan on writing some NLP-based tools, so I hope to start contributing again.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
oxinabox commentedJan 29, 2018
•
edited
Hi @jbn,
this PR makes it so that the data is automatically downloaded.
See https://github.com/oxinabox/DataDeps.jl
Using it in WordNet.jl for this, is one of packages I had in mind when I was making DataDeps.
So if it is not going to be useful for this,
I would say that it is a problem with DataDeps.jl that need to be fixed (and a failure on my part -- I'ld appreciate the feedback).
This might need to wait for JuliaLang/METADATA.jl#13140
before it passes CI.
It also might want a CI test to check it can indeed construct one with no parameters, using the datadep.
That would involve setting the environment variable
DATADEPS_ALWAYS_ACCEPT=true
(to bypass the "Do you want to download?" screen.Maybe even adding a cron test in travis to rerun periodically to check it the URL hasn't broken