Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DataDeps.jl for downloading #8

Merged
merged 5 commits into from Feb 16, 2018
Merged

Conversation

@oxinabox
Copy link
Contributor

oxinabox commented Jan 29, 2018

Hi @jbn,
this PR makes it so that the data is automatically downloaded.
See https://github.com/oxinabox/DataDeps.jl

Using it in WordNet.jl for this, is one of packages I had in mind when I was making DataDeps.
So if it is not going to be useful for this,
I would say that it is a problem with DataDeps.jl that need to be fixed (and a failure on my part -- I'ld appreciate the feedback).

This might need to wait for JuliaLang/METADATA.jl#13140
before it passes CI.

It also might want a CI test to check it can indeed construct one with no parameters, using the datadep.
That would involve setting the environment variable DATADEPS_ALWAYS_ACCEPT=true (to bypass the "Do you want to download?" screen.
Maybe even adding a cron test in travis to rerun periodically to check it the URL hasn't broken

oxinabox added 5 commits Jan 29, 2018
@jbn

This comment has been minimized.

Copy link
Collaborator

jbn commented Feb 5, 2018

This looks good to me. But, I'm in the make-or-break stage of my dissertation, so my review is cursory at best. @oxinabox you seem to be either the main or one of the main organizers for JuliaText. If you have pull rights, I think you're in a better position than I am to make these important decisions.

@oxinabox

This comment has been minimized.

Copy link
Contributor Author

oxinabox commented Feb 6, 2018

Fair enough,
I also am heading that way on my own PhD work, good luck.
I'll give it a second look-over myself, and merge.

@jbn

This comment has been minimized.

Copy link
Collaborator

jbn commented Feb 7, 2018

(Just, FYI: @oxinabox. I should be wrapping up sometime in June / July. After which, I plan on writing some NLP-based tools, so I hope to start contributing again.)

@oxinabox oxinabox merged commit 057986c into JuliaText:master Feb 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@oxinabox oxinabox deleted the oxinabox:ox/datadeps branch Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.