Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TokTok.jl #29

Merged
merged 6 commits into from
Jun 21, 2019
Merged

Fix TokTok.jl #29

merged 6 commits into from
Jun 21, 2019

Conversation

Ayushk4
Copy link
Member

@Ayushk4 Ayushk4 commented Jun 20, 2019

Refer #28

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #29 into master will increase coverage by 18.39%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #29       +/-   ##
===========================================
+ Coverage   75.88%   94.27%   +18.39%     
===========================================
  Files          10       10               
  Lines         651      524      -127     
===========================================
  Hits          494      494               
+ Misses        157       30      -127
Impacted Files Coverage Δ
src/words/TokTok.jl 100% <100%> (+19.48%) ⬆️
src/sentences/sentence_splitting.jl 98.11% <0%> (+9.97%) ⬆️
src/words/nltk_word.jl 100% <0%> (+10%) ⬆️
src/words/fast.jl 98.14% <0%> (+16.32%) ⬆️
src/words/tweet_tokenizer.jl 91.15% <0%> (+19.11%) ⬆️
src/words/sedbased.jl 100% <0%> (+84.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f910c2c...00cdf78. Read the comment docs.

@Ayushk4 Ayushk4 mentioned this pull request Jun 21, 2019
@Ayushk4
Copy link
Member Author

Ayushk4 commented Jun 21, 2019

@oxinabox I believe this is done from my side, pls review.

@Ayushk4
Copy link
Member Author

Ayushk4 commented Jun 21, 2019

Here is one small difference b/w 1.1 and 1.0 that caused error in one of the newly added test cases. (Now fixed)

1.1

julia> collect.(Iterators.flatten(["–—", ("'", "’")]))
4-element Array{Array{Char,N} where N,1}:
 '–'   
 '—'   
 ['\'']
 ['’'] 

1.0

julia> collect.(Iterators.flatten(["–—", ("'", "’")]))
4-element Array{Array{Char,1},1}:
 ['–'] 
 ['—'] 
 ['\'']
 ['’'] 

@oxinabox oxinabox merged commit 02d86de into JuliaText:master Jun 21, 2019
@oxinabox
Copy link
Member

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants