Separate HTTP.request from Layers.request

[fredrikekre]

No description provided.

[quinnj]

I like the changes here; what's the status @fredrikekre ? I see it's still marked WIP?

[fredrikekre]

I can update it if you want, wasn't sure the changes were desired and, hence, the draft.

This will break packages that insert their own layers, but maybe that is just the AWS packages? Either it needs a breaking new version here or those packages need to be fixed.

[quinnj]

I'd ideally like to get #486 and this PR into a new minor release soon; @fredrikekre, are you able/willing to update here?

[fredrikekre]

Sure.

[codecov-io]

Codecov Report

Merging #469 (ce0c1d9) into master (337a372) will decrease coverage by 8.43%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   77.53%   69.10%   -8.44%     
==========================================
  Files          36       36              
  Lines        2333     1780     -553     
==========================================
- Hits         1809     1230     -579     
- Misses        524      550      +26     

Impacted Files	Coverage Δ
src/CanonicalizeRequest.jl	0.00% <0.00%> (ø)
src/ContentTypeRequest.jl	0.00% <0.00%> (ø)
src/DebugRequest.jl	0.00% <0.00%> (-12.50%)	⬇️
src/layers.jl	86.66% <0.00%> (-13.34%)	⬇️
src/AWS4AuthRequest.jl	80.95% <100.00%> (+1.58%)	⬆️
src/BasicAuthRequest.jl	100.00% <100.00%> (ø)
src/ConnectionRequest.jl	62.16% <100.00%> (+13.72%)	⬆️
src/CookieRequest.jl	94.73% <100.00%> (+7.64%)	⬆️
src/ExceptionRequest.jl	83.33% <100.00%> (-2.39%)	⬇️
src/HTTP.jl	96.00% <100.00%> (-4.00%)	⬇️
... and 37 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337a372...55e1328. Read the comment docs.

[quinnj]

This LGTM now. @mattBrzezinski @oxinabox @omus @iamed2 , will this break existing custom layers people have defined elsewhere? If so, we can rename the PR to [BREAKING] and try to announce the change.

[mattBrzezinski]

This LGTM now. @mattBrzezinski @oxinabox @omus @iamed2 , will this break existing custom layers people have defined elsewhere? If so, we can rename the PR to [BREAKING] and try to announce the change.

If you remove the Layers prefix, here, and the tests fail then it'll be a breaking change.

[quinnj]

@fredrikekre, are you up for updating this PR to get it merged soon for a 1.0 release?

[quinnj]

Included in #789