Set Content-Type correctly with body::Form #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and schedule non-conforming method HTTP.post(uri, f::Form) method for deprecation in the next breaking release.
fredrikekre
force-pushed
the
fe/content-type
branch
from
a5fca8d to
bf38e40
Compare
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 75.85% 76.54% +0.68%
==========================================
Files 36 36
Lines 1922 1923 +1
==========================================
+ Hits 1458 1472 +14
+ Misses 464 451 -13
Continue to review full report at Codecov.
|
Member
|
I don't have approve permissions. But looks good to me, ship it! |
Member
|
Travis is consistently timing out running the server tests, but the tests here all run before that and passed, so I think we're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.