Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unusual return symbol #59

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

MaxGyver83
Copy link
Contributor

Fix #53.

Before:
return key upside down

After:
Screenshot_2022-02-02-22-15-37-09_c7d7c78e17792d54d6e4296d9f6a5da4

@sdrapha
Copy link
Contributor

sdrapha commented Feb 3, 2022

Instead of replacing the char for a different unicode char. Could the change be done on the current icon inside the .ttf instead? This way it could be a nicer looking symbol, not just the outline. I'm also afraid of plain unicode chars looking different across devices, with different system fonts. There was an old version of this keyboard that the PG_UP and PG_DOWN rendered as weird blue squares icons that was part of the system font on my phone.
I'm not sure if that is really an issue, but wanted to share my viewpoint.

@MaxGyver83
Copy link
Contributor Author

I'm also afraid of plain unicode chars looking different across devices, with different system fonts.

Good point!

Could the change be done on the current icon inside the .ttf instead?

I think this is possible. I just don't know how to modifiy a .ttf file. But I'm sure @Julow knows how to do it.

@Julow
Copy link
Owner

Julow commented Feb 6, 2022

@sdrapha is right, the included ttf needs to be changed too. And I'd prefer a full and lighter symbol too.
But the char needs to be changed too, so the font is not too wrong.
I'll merge this and work on the font later, which needs more work than just modifying a glyph. I'd like to keep the glyph in text format (perhaps svg) and build the font deterministically because font editing softwares are a pain to use.

Thanks !

@Julow Julow merged commit d014a7d into Julow:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return/enter symbol upside down
3 participants