From bb03ec781b8e07d86054bc8b0cc359801dbef1d8 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Fri, 1 May 2026 15:15:40 -0600 Subject: [PATCH] fix(refresh): skip _shim-* files in orphan check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit generate-shims.sh produces _shim-*.md files in agents/review/ as generated artifacts, not synced content. The orphan check in sync-reviewers.sh previously flagged every one of them as "not in any configured source" on every sync — pure noise that made it harder to spot real orphans (e.g., when removing a configured source and wanting to clean up the files it had been producing). Extends the existing _template-reviewer.md skip to a case glob that also matches _shim-*. Matches the convention that underscore- prefixed files in this directory are internal/generated, not synced content. Discovered while cleaning up duplicate orchestrator-as-reviewer sources in reviewer-sources.yaml — every reviewer sync produced ~20 lines of orphan warnings for the auto-regenerated shim files. Co-Authored-By: Claude Opus 4.7 (1M context) --- plugins/compound-engineering/skills/refresh/sync-reviewers.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/compound-engineering/skills/refresh/sync-reviewers.sh b/plugins/compound-engineering/skills/refresh/sync-reviewers.sh index 31274f818..85712e635 100755 --- a/plugins/compound-engineering/skills/refresh/sync-reviewers.sh +++ b/plugins/compound-engineering/skills/refresh/sync-reviewers.sh @@ -295,7 +295,9 @@ echo "" for filepath in "$OUTPUT_DIR"/*.md; do [ -f "$filepath" ] || continue filename=$(basename "$filepath") - [ "$filename" = "_template-reviewer.md" ] && continue + case "$filename" in + _template-reviewer.md|_shim-*) continue ;; + esac if [ ! -f "${staging}/${filename}" ]; then echo " Orphan: ${filename} (not in any configured source)" fi