From cc13118ccfb5bab06be65bb900f5307303c761fc Mon Sep 17 00:00:00 2001 From: Babu Shanmugam Date: Tue, 30 Dec 2014 09:49:32 +0000 Subject: [PATCH] Avoid repeatedly allocating StreamHandler for SandeshLogger Change-Id: I37dd478eaedd1dcb182f8819c426fe940dc4bb03 Closes-Bug: #1405245 --- library/python/pysandesh/sandesh_logger.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/library/python/pysandesh/sandesh_logger.py b/library/python/pysandesh/sandesh_logger.py index 9937b34a..81feb966 100644 --- a/library/python/pysandesh/sandesh_logger.py +++ b/library/python/pysandesh/sandesh_logger.py @@ -41,11 +41,15 @@ def __init__(self, generator): self._logger = logging.getLogger(self._generator) self._logging_level = SandeshLevel.SYS_INFO self._logger.setLevel(SandeshLogger.get_py_logger_level(self._logging_level)) - self._logging_file_handler = logging.StreamHandler() - log_format = logging.Formatter('%(asctime)s [%(name)s]: %(message)s', - datefmt='%m/%d/%Y %I:%M:%S %p') - self._logging_file_handler.setFormatter(log_format) - self._logger.addHandler(self._logging_file_handler) + if not len(self._logger.handlers): + # add the handler only once + self._logging_file_handler = logging.StreamHandler() + log_format = logging.Formatter('%(asctime)s [%(name)s]: %(message)s', + datefmt='%m/%d/%Y %I:%M:%S %p') + self._logging_file_handler.setFormatter(log_format) + self._logger.addHandler(self._logging_file_handler) + else: + self._logging_file_handler = self._logger.handlers[0] #end __init__ @staticmethod