Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no custom method sorting #189

Merged
merged 1 commit into from Sep 26, 2019
Merged

no custom method sorting #189

merged 1 commit into from Sep 26, 2019

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Sep 26, 2019

Fixes #189.

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #189 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   28.65%   28.24%   -0.42%     
==========================================
  Files          35       35              
  Lines        1518     1526       +8     
==========================================
- Hits          435      431       -4     
- Misses       1083     1095      +12
Impacted Files Coverage Δ
src/display/methods.jl 70% <ø> (-15.72%) ⬇️
src/display/base.jl 27.11% <0%> (-4.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9af7cb...becfe73. Read the comment docs.

@pfitzseb pfitzseb merged commit 575cc2f into master Sep 26, 2019
@pfitzseb pfitzseb deleted the sp/nomethsort branch September 26, 2019 16:22
aviatesk added a commit that referenced this pull request Sep 27, 2019
aviatesk added a commit that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant