-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Error upon interrupt signal #309
Comments
Here is another occurrence (without the red warning box) that happened when hitting CTRL+C while writing a string. The two stacktraces are different so it may be unrelated apart from the fact that the error was triggered after an interrupt. Stacktrace:
|
Hm, if you interrupt Juno while we're doing some internal work then this happens, yes, but I'm not sure what to do about it. Could look into making the communication task un-interruptible, maybe, but occasionally that's pretty useful too... (unless it crashes Julia, of course). |
Fair enough, thanks. Would you know a way to catch this more or less cleanly on the package side? Or more generally would you have an idea of how to have long-running loops that are expected to be eventually killed by the user (e.g. HTTP's listen loop) isolated from their environment in such a way that this doesn't happen? I tried wrapping things in an async task but catching an interrupt properly and forwarding it to a task is currently a PITA as far as I could see (and I don't think it circumvents the issue). thanks (and I guess this issue can be closed) |
I'd suggest running the HTTP serve in the Juno REPL, that way interrupts are much more likely to end up in the right place in my experience. Or you start the serve in a async task and explicitly kill that (not with ^C). Also let's leave this open for now as a reminder that Juno should be smarter about interrupt handling ;) |
This should be fixed now, btw. |
Please search existing issues to avoid duplicates.
Details
Steps to reproduce
Not reproducible in a deterministic way afaict. It only happened once to me thus far.
My context:
The text was updated successfully, but these errors were encountered: