Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor formatters.jl #355

Merged
merged 4 commits into from
May 30, 2020
Merged

refactor formatters.jl #355

merged 4 commits into from
May 30, 2020

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented May 25, 2020 •
edited
Loading

first step towards #308

  • rename formatters.jl -> formats.jl since it defines formats rather than those who do actual formatting/rendering task
  • introduce @define_format macro and reduce verbosity
  • move description field into formatdict

@aviatesk aviatesk changed the title wip: refactor formatters.jl refactor formatters.jl May 30, 2020
@aviatesk aviatesk merged commit 5b959a9 into master May 30, 2020
@aviatesk aviatesk mentioned this pull request May 30, 2020
Merged
@aviatesk aviatesk added this to the v0.11 milestone May 31, 2020
@aviatesk aviatesk added the refactor this packages needs HUGE refactor label May 31, 2020
@aviatesk aviatesk deleted the avi/refactorformatters branch May 31, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor this packages needs HUGE refactor
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
1 participant
@aviatesk